Repository navigation
fix(server): provider refresh finds CLIs installed after launch on macOS and Linux - #40693
Conversation
…OS and Linux Failing test for #34354: refresh re-reads only the Windows registry PATH, so a CLI installed after startup stays not found until the server restarts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cOS and Linux Refreshing provider status re-read PATH only from the Windows registry, so on macOS and Linux a claude or codex added to the shell profile after the server started stayed "not found on PATH" until a restart. The refresh now also re-reads the login shell, and rebuilds instances still missing their CLI whenever PATH differs from what the registry last saw, so a PATH that Source control discovery already refreshed also reaches Claude's driver. Fixes #34354 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
**v0.1.12-nightly.20261122.5085** · 20 changes from 10 contributors - **Reliable image sends.** Messages now wait for images to finish uploading before sending. - **Rich text pasting.** Paste text from Microsoft Word and other rich text apps into the composer instead of attaching an image. - **Provider refresh.** Refresh providers to find newly installed Claude or Codex without restarting the server on macOS and Linux. - **Scheduled task drafts.** Clicking outside the scheduled task editor no longer discards your draft. ### Plus 16 more bug fixes and performance improvements. <details> <summary>Full changelog</summary> ## What's Changed * perf(shared): Windows command lookups reuse PATH listings across requests by @juliusmarminge in pingdotgg/t3code#40634 * fix(mcp): t3_thread_wait no longer has parents poll a task's first run by @navidnadali in pingdotgg/t3code#40633 * fix(server): reveal no longer opens Explorer's default folder for a missing file by @juliusmarminge in pingdotgg/t3code#40637 * fix(server): a steer that missed its turn keeps its place in the queue by @navidnadali in pingdotgg/t3code#40622 * fix(web): wrapped prompt suggestion no longer overlaps the composer toolbar by @juliusmarminge in pingdotgg/t3code#40654 * fix(server): refuse ref switches while a thread works in the shared checkout by @gbrasil720 in pingdotgg/t3code#38271 * fix(server): label speaker notes in OpenDocument attachments by @geezoria in pingdotgg/t3code#38542 * fix(server): folder discovery skips the walk when t3.json ignores the whole project by @juliusmarminge in pingdotgg/t3code#40664 * fix(server): checkpoint repository scopes walk the project folder once per turn by @Sidreyas in pingdotgg/t3code#40671 * fix(server,cursor): preserve inline handoff when a failed Cursor turn drops its prompt by @MIT-Consulting in pingdotgg/t3code#40670 * perf(web): Markdown renders with Words as static islands under one shared tooltip; remark leaves the web app by @juliusmarminge in pingdotgg/t3code#27866 * fix(web): pasting text copied from Word inserts the text instead of an image by @juliusmarminge in pingdotgg/t3code#40686 * fix(web): wait for image uploads before sending by @Yash-Singh1 in pingdotgg/t3code#40672 * fix(server): provider refresh finds CLIs installed after launch on macOS and Linux by @juliusmarminge in pingdotgg/t3code#40693 * fix(mobile): replace undefined text-foreground-subtle token with text-foreground-muted by @MIT-Consulting in pingdotgg/t3code#40676 * fix(antigravity): a long shell command keeps its start, not its last 8,000 characters by @juliusmarminge in pingdotgg/t3code#40702 * fix(server): setup script output no longer ends in half an emoji by @tiliakoos in pingdotgg/t3code#40701 * fix(server): text generation no longer falls back to a model that cannot generate text by @tiliakoos in pingdotgg/t3code#40699 * fix(client-runtime): typing a bare Windows drive lists its folders by @brunobola in pingdotgg/t3code#40682 * fix(web): a click outside the scheduled task editor no longer discards the draft by @Jardo-51 in pingdotgg/t3code#40708 ## New Contributors * @gbrasil720 made their first contribution in pingdotgg/t3code#38271 * @MIT-Consulting made their first contribution in pingdotgg/t3code#40670 * @brunobola made their first contribution in pingdotgg/t3code#40682 **Full Changelog**: pingdotgg/t3code@v0.1.12-nightly.20261122.5071...v0.1.12-nightly.20261122.5085 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.12-nightly.20261122.5085
…cOS and Linux (pingdotgg#40693) (cherry picked from commit 122d3bf)
On macOS and Linux the server read the login-shell PATH only at startup. A
claudeorcodexinstalled afterwards stayed "not found on PATH" through every provider refresh until the server restarted. A provider refresh now re-reads the login shell and rebuilds providers still missing their CLI whenever PATH has changed.ProviderRegistry's host-PATH refresh now callsrefreshPathFromLoginShell()alongside the Windows registry refresh.Fixes #34354
Reproduction on main
Commit f9b19a7 (origin/main), Linux. Started
T3CODE_DEV_SEED=0 vp run devwith SHELL pointing at a scratch login-shell wrapper that sources a scratch rc file and logs each read. Set Claude's Binary path toclaude-lateand Codex's tocodex-late(neither on PATH). Settings → Providers showed both 'Not found'. Then put symlinks to the real claude/codex in a new folder and appended it to PATH in the rc file; a new-ilclogin shell resolved both. Clicked 'Refresh provider status': the provider caches got a new checkedAt (05:35:22, after the rc change), both still installed=false ('Claude Agent CLI (claude) was not found on PATH.', 'Could not start Codex CLI (codex-late)'), and the rc log showed no read by the server. The server process's environment PATH had no entry for the new folder. Opening Settings → Source control & issues made the server read the login shell (rc log entry 05:35:51); the next refresh showed Codex installed v0.171.0 while Claude stayed 'not found on PATH'. Failing test: ProviderRegistry.test.ts 'rebuilds only instances missing their CLI when a refresh finds a new login-shell PATH' fails on main (PATH stays '/usr/bin', expected '/opt/late:/usr/bin'); the existing Windows row passes. A local change making refreshHostPath also call refreshPathFromLoginShell made both rows pass (not committed).Evidence
Linux, Chromium, 1280×800, light theme; fresh isolated state on each commit. Configure claude-late and codex-late while absent from PATH, refresh to establish Not found, add their real CLI symlink folder to the login-shell profile, verify resolution in a new login shell, wait for Checked 1m ago, and refresh again without restarting.
Scenario · Fixture setup · Runner proof
The runner exited 0: failsOnBase=true and passesOnHead=true. Limitation observed in an earlier run: refreshing again immediately after the initial check still leaves both missing on head because the PATH probe is cached for 10 seconds. The paired proof above waits beyond that cache.
Not shown:
Tests
vp test run src/provider/ProviderRegistry.test.ts -t "rebuilds only instances"on the repro branch before the fix: the login-shell row failed (expected '/opt/late:/usr/bin', got '/usr/bin') and the Windows row passedvp test run src/provider/ProviderRegistry.test.ts src/provider/providerCompatibility.test.ts src/secrets/SecretCheck.test.ts src/sourceControl src/os-jank.test.ts: 9 files, 209 tests passedvp run check:changed: format, lint, knip, graphql, typecheck (3 packages) and tests (3 files, 105 tests) all passedNot in this change
refreshWindowsPathstill returns a boolean that ProviderRegistry no longer reads; left as is to keep the change small.Who did the work
Run by the t3code factory in T3 Code.